Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JAAS tutorial #45

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Update JAAS tutorial #45

merged 4 commits into from
Jun 3, 2024

Conversation

kian99
Copy link
Contributor

@kian99 kian99 commented May 24, 2024

Update the JAAS tutorial with improvements based on actually trying to deploy and use the JIMM server.

babakks
babakks approved these changes May 29, 2024
View reviewed changes
tutorial/deploy_jimm_microk8s.rst Outdated Show resolved Hide resolved
tutorial/deploy_jimm_microk8s.rst Outdated Show resolved Hide resolved
tutorial/deploy_jimm_microk8s.rst Show resolved Hide resolved
kian99 added 3 commits May 30, 2024 15:25
@kian99
Update JAAS tutorial
953c0f5
@kian99
Update tutorial to mention nip.io
b4a2de2 
Suggest use of nip.io for setting up external identity provider
@kian99
PR changes
53adbac
@kian99 kian99 force-pushed the tutorial-tweaks branch from c9367ca to 53adbac Compare May 30, 2024 13:28
babakks
babakks approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@babakks babakks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, I think we should only update the custom_wordlist file for JIMM-specific words.

@kian99
Copy link
Contributor Author

kian99 commented May 30, 2024

By the way, I think we should only update the custom_wordlist file for JIMM-specific words.

I was wondering about that, but the spelling errors for hostname and hostnames went away after I added them to the wordlist so I'm not sure what's the best approach

@kian99 kian99 merged commit c64fba8 into canonical:v3 Jun 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babakks babakks babakks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kian99 @babakks