Replace final-redirect-url with juju-dashboard-location
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Babak K. Shandiz <[email protected]>
babakks
force-pushed
the
css-8764/remove-dashboard-redirect-uri-references
branch
from
4ac1244 to
3cd7c7d
Compare
alesstimec
approved these changes
May 30, 2024
kian99
reviewed
May 30, 2024
| # A final redirect URL for login, normally set to the URL of the Juju dashboard. | ||
| juju config jimm final-redirect-url="http://test-jimm.localhost/auth/whoami" | ||
|
|
||
| Optionally, if you have deployed Juju Dashboard, you can configure JIMM to enable browser flow for authentication: |
There was a problem hiding this comment.
Let's tweak this slightly for the purposes of the tutorial so that the dashboard location is still configured so that the user can still test the browser flow. What do you think?
There was a problem hiding this comment.
Yeah, sure. I'll set it with the same /auth/whoami we had, but will point out that this should be replaced with dashboard URL.
Signed-off-by: Babak K. Shandiz <[email protected]>
kian99
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the reference to
final-redirect-urlconfig option, withjuju-dashboard-location. This is a follow-up to canonical/jimm#1217.Fixes CSS-8764