-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add JAAS security doc #62
Conversation
- The doc covers the use of cryptography in JAAS, algorithms used and packages used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very well done, some suggestions
reference/security.rst
Outdated
^^^^^^^^^^^^^^^^^ | ||
|
||
JAAS does not currently enforce TLS when communicating with PostgreSQL. | ||
But this can be achieved when using the PostgreSQL charm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put this differently.
It is possible to achieve TLS by using the PostgresSQL charm and configure it properly by following https://charmhub.io/postgresql-k8s/docs/t-enable-tls
reference/security.rst
Outdated
malicious use of your online credentials. Read more on CORS | ||
`here <https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#what_requests_use_cors>`__. | ||
|
||
JAAS supports the use of CORS headers specifically for the purposes of the Juju |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add that CORS is not supported for WS communications?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I'll need to mention that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing doc! Thanks for this.
- used LLM to simplify wording where possible
@babakks @SimoneDutto I was curious if an LLM could improve my wording and since these are public docs I tried it and was quite impressed with the changes. If you want, please take another look. The latest commit is purely the LLM changes after I went over them and accepted the changes I wanted, for example I wasn't happy with the changes to the Macaroon section so I left that one as is. I'll address your comments now. Many have already been solved. |
ae0dc2a
to
1bbecc2
Compare
1bbecc2
to
5f84416
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments, I'll lgtm it but plz do them
Description
This PR adds a doc titled "JAAS Security".
The doc covers any areas that are important to the security of JAAS.
Where relevant we cover the use of cryptography, algorithms used and packages used.
Resolves: CSS-9384