Skip to content

Commit

Permalink
fixes a flaky test that expected ordering (#1424)
Browse files Browse the repository at this point in the history
OpenFGA does not provide any ordering guarantees on the results provided. Remove testing for this.
  • Loading branch information
kian99 authored Nov 11, 2024
1 parent 2067d6d commit 42a9939
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions internal/jimmhttp/rebac_admin/groups_integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ func (s rebacAdminSuite) TestGetGroupIdentitiesIntegration(c *gc.C) {
c.Assert(*res.Meta.PageToken, gc.Equals, "")
c.Assert(*res.Next.PageToken, gc.Not(gc.Equals), "")
c.Assert(res.Data, gc.HasLen, 5)
c.Assert(res.Data[0].Email, gc.Equals, "foo0@canonical.com")
c.Assert(res.Data[0].Email, gc.Matches, `foo\d@canonical\.com`)

// Request next page
params.NextPageToken = res.Next.PageToken
Expand All @@ -68,7 +68,7 @@ func (s rebacAdminSuite) TestGetGroupIdentitiesIntegration(c *gc.C) {
c.Assert(*res.Meta.PageToken, gc.Equals, *params.NextPageToken)
c.Assert(res.Next.PageToken, gc.IsNil)
c.Assert(res.Data, gc.HasLen, 5)
c.Assert(res.Data[0].Email, gc.Equals, "foo5@canonical.com")
c.Assert(res.Data[0].Email, gc.Matches, `foo\d@canonical\.com`)

// Request all items, no next page.
allItems := &resources.GetGroupsItemIdentitiesParams{}
Expand Down

0 comments on commit 42a9939

Please sign in to comment.