Fix dial controller and monitoring (#1264)

canonical · Jul 8, 2024 · 5d366fb · 5d366fb
1 parent c847db5
commit 5d366fb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/jimm/watcher.go b/internal/jimm/watcher.go
@@ -138,7 +138,7 @@ func (w *Watcher) dialController(ctx context.Context, ctl *dbmodel.Controller) (
 		if !updateController {
 			return
 		}
-		if uerr := w.Database.UpdateController(ctx, ctl); err != nil {
+		if uerr := w.Database.UpdateController(ctx, ctl); uerr != nil {
 			zapctx.Error(ctx, "cannot set controller available", zap.Error(uerr))
 		}
 		// Note (alesstimec) This channel is only available in tests.

diff --git a/internal/servermon/monitoring.go b/internal/servermon/monitoring.go
@@ -113,7 +113,7 @@ var (
 		Name:      "errors_total",
 		Help:      "The number of monitoring errors found.",
 	}, []string{"controller"})
-	WebsocketRequestDuration = promauto.NewSummaryVec(prometheus.SummaryOpts{
+	WebsocketRequestDuration = promauto.NewHistogramVec(prometheus.HistogramOpts{
 		Namespace: "jimm",
 		Subsystem: "websocket",
 		Name:      "request_duration_seconds",