Skip to content

Commit

Permalink
bad comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ale8k committed Mar 7, 2024
1 parent dbeb34e commit 7f9b68e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion internal/auth/oauth2.go
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ func (as *AuthenticationService) Email(idToken *oidc.IDToken) (string, error) {
// via an access token. The token only contains the user's email for authentication.
func (as *AuthenticationService) MintSessionToken(email string, secretKey string) (string, error) {
const op = errors.Op("auth.AuthenticationService.MintAccessToken")

token, err := jwt.NewBuilder().
Subject(email).
Expiration(time.Now().Add(as.sessionTokenExpiry)).
Expand Down
2 changes: 1 addition & 1 deletion internal/jimmhttp/auth_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ func (oah *OAuthHandler) Callback(w http.ResponseWriter, r *http.Request) {
}

session.IsNew = true // Sets cookie to a fresh new cookie
session.Options.MaxAge = oah.cookieExpiry // 24 Hours expiry
session.Options.MaxAge = oah.cookieExpiry // Expiry in seconds
session.Options.Secure = oah.secureCookies // Ensures only sent with HTTPS
session.Options.HttpOnly = false // Allow Javascript to read it

Expand Down

0 comments on commit 7f9b68e

Please sign in to comment.