Drops old facade versions. #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeps only the latest facade versions - ones used by the latest 2.9 controller.
alesstimec
requested review from
kian99,
ale8k,
babakks and
mina1460
as code owners
kian99
approved these changes
Nov 14, 2023
| @@ -21,7 +21,7 @@ import ( | |||
| // ModelManager facade. | |||
| func (c Connection) CreateModel(ctx context.Context, args *jujuparams.ModelCreateArgs, info *jujuparams.ModelInfo) error { | |||
| const op = errors.Op("jujuclient.CreateModel") | |||
| if err := c.CallHighestFacadeVersion(ctx, "ModelManager", []int{9, 2}, "", "CreateModel", args, info); err != nil { | |||
There was a problem hiding this comment.
Wouldn't we want to keep this pattern for future facade versions?
There was a problem hiding this comment.
yes, we would.. but we'll change it once there is a newer facade version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Keeps only the latest facade versions - ones used by the latest 2.9 controller - as discussed at the engineering sprint in Riga (23.10). This means only 2.9 (and 3.x) clients will be able to to talk to this version of JIMM.
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers