Remove unused tables and columns #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
requested review from
alesstimec,
ale8k,
babakks and
mina1460
as code owners
kian99
force-pushed
the
remove-unused-tables
branch
from
b9ae714 to
87792fd
Compare
mina1460
approved these changes
Nov 21, 2023
alesstimec
reviewed
Nov 21, 2023
| ALTER TABLE users DROP COLUMN controller_access; | ||
| ALTER TABLE users DROP COLUMN audit_log_access; | ||
|
|
||
| UPDATE versions SET major=1, minor=4 WHERE component='jimmdb'; |
There was a problem hiding this comment.
shouldn't we increase the minor? and for sqlite as well?
There was a problem hiding this comment.
It has been increased, the previous migration was 1.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following on from #1093, we can now remove all unused tables and columns that were previously used for access checks in Postgres.
Engineering checklist
Check only items that apply