Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes the discharge endpoint #1118

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

alesstimec
Copy link
Collaborator

Description

The discharge endpoint will now accept only is-consumer <user tag> <offer uuid> format of the caveat.
If user has consumer relation to the application offer, the discharge macaroon will contain a delared caveat offer-uuid <offer uuid> to maintain compatibility with juju controllers.

Engineering checklist

Check only items that apply

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

Test instructions

Notes for code reviewers

Copy link

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git commit -S --amend --no-edit) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@alesstimec alesstimec force-pushed the discharger-change branch 3 times, most recently from feabf46 to b198079 Compare January 3, 2024 12:50
discharger.go Show resolved Hide resolved
service_test.go Outdated Show resolved Hide resolved
service_test.go Show resolved Hide resolved
The discharge endpoint will now accept only
`is-consumer <user tag> <offer uuid>` format
of the caveat.
If user has `consumer` relation to the application
offer, the discharge macaroon will containe a
delared caveat `offer-uuid <offer uuid>` to maintain
compatibility with juju controllers.
@alesstimec alesstimec merged commit 31f3423 into canonical:v3 Jan 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants