The birth of a new river #1135
Merged
The birth of a new river #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mina1460
requested review from
alesstimec,
kian99,
ale8k and
babakks
as code owners
alesstimec
requested changes
Jan 17, 2024
alesstimec
approved these changes
Jan 17, 2024
alesstimec
requested changes
Jan 17, 2024
- Ensure River uses the correct test DB. - Ensure River receives a database that has already been migrated.
- Fix jujuclient suites to properly clean up. - Add wait in method where we insert river job
Distributed transaction fixes
kian99
reviewed
Jan 29, 2024
mina1460
commented
Jan 29, 2024
babakks
reviewed
Jan 29, 2024
kian99
reviewed
Jan 29, 2024
internal/jimm/river.go
Outdated
| } | ||
|
|
||
| // NewRiverArgs is a struct that represents | ||
| type NewRiverArgs struct { |
There was a problem hiding this comment.
Agreed with either. The function that creates a RiverConfig or RiverParams should have New in the name.
kian99
reviewed
Jan 30, 2024
There was a problem hiding this comment.
Just trying to note down the discussion we had yesterday,
- Regarding a timeout on the context (or a full timer), I'm not sure whether we decided to add this.
- We need to check that on EventKindJobFailed we check the job failed all retries. We should probably also check whether we don't want to listen for the other job kinds?
- We need to merge this into a feature branch.
kian99
reviewed
Jan 31, 2024
kian99
approved these changes
Jan 31, 2024
alesstimec
approved these changes
Jan 31, 2024
alesstimec
reviewed
Jan 31, 2024
mina1460
merged commit add706a
into
canonical:feature-distributed-transactions
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers