CSS-6952 add service account command #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
requested review from
alesstimec,
ale8k,
babakks and
mina1460
as code owners
babakks
approved these changes
Jan 29, 2024
babakks
approved these changes
Jan 29, 2024
ale8k
approved these changes
Jan 30, 2024
updated godoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a CLI command and test for addServiceAccount, the method that grants a user with permission to a service account.
The PR is larger than expected because testing the new CLI application uses the same test suite as the one that existed in
cmd/jimmctl/cmd/jimmsuite_test.go. To avoid duplication this code has been moved tointernal/cmdtest/jimmsuite.goand imported fromcmd/jimmctl/cmdtests andcmd/serviceaccounts/cmdtests.Fixes CSS-6952
Engineering checklist
Check only items that apply