CSS-6718 add oauth relation to k8s charm #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
requested review from
alesstimec,
ale8k,
babakks and
mina1460
as code owners
alesstimec
approved these changes
Feb 26, 2024
nsklikas
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
LGTM
If you want to add integration tests for this you can check out https://github.com/canonical/iam-bundle/tree/main/oauth_tools. It deploys the whole iam bundle and provides some helper functions. Currently it is very rough but we are going to refactor it in the future. The interface is going to remain the same though, so it shouldn't cause you any trouble.
See the grafana tests for an example: https://github.com/canonical/grafana-k8s-operator/blob/main/tests/integration/test_grafana_oauth.py
nsklikas
reviewed
Feb 26, 2024
mina1460
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the OAuth relation library to JIMM. Note that the relation library comes form the hydra-operator.
This PR is heavily inspired by the Grafana charms integration with the same library in canonical/grafana-k8s-operator#278
Fixes CSS-6718
Engineering checklist
Check only items that apply