RIP Candid - Follow up

[kian99]

Description

Follow up on previous PR comments, addressing 3 issues:

• Use a checker in NewUserSessionLogin to fail the test instead of a panic.
• Added Godoc to NewUserSessionLogin.
• Fixed incorrect string in internal/jimm/access_test.go

[alesstimec]

LGTM

[alesstimec]

nitpick: we're not using Logf anywhere..

[kian99]

Yeah I just used the Tester interface and left in only what both the GoCheck and QuickTest testers implement. Might be handy in the future at a glance.

[babakks]

We already have one in internal/jimmtest/gorm.go. I think you can safely use that:

// A Tester is the test interface required by this package.
type Tester interface {
	Fatalf(format string, args ...interface{})
	Logf(format string, args ...interface{})
	Name() string
	Cleanup(f func())
}

[kian99]

I tried to but GoCheck doesn't implement all of those so instead of using the wrapper struct I just made a SimpleTester interface instead. In most places we have a GoCheck tester and in some places a qt tester and I didn't want to change the caller code to wrap the GoCheck tester in a struct before passing it.

[babakks]

We already have one in internal/jimmtest/gorm.go. I think you can safely use that:

// A Tester is the test interface required by this package.
type Tester interface {
	Fatalf(format string, args ...interface{})
	Logf(format string, args ...interface{})
	Name() string
	Cleanup(f func())
}