Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Juju monitoring #1234

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Juju monitoring #1234

merged 3 commits into from
Jun 13, 2024

Conversation

alesstimec
Copy link
Collaborator

Description

The what and why - include a summary of the change, describe what it does, and include relevant motivation and context.

Fixes JIRA/GitHub issue number

Engineering checklist

Check only items that apply

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

Test instructions

Notes for code reviewers

internal/jujuclient/dial.go Show resolved Hide resolved
internal/rpc/client_test.go Outdated Show resolved Hide resolved
internal/rpc/proxy.go Outdated Show resolved Hide resolved
internal/rpc/proxy.go Outdated Show resolved Hide resolved
internal/rpc/proxy.go Outdated Show resolved Hide resolved
internal/rpc/proxy.go Outdated Show resolved Hide resolved
internal/rpc/proxy.go Outdated Show resolved Hide resolved
internal/rpc/proxy.go Outdated Show resolved Hide resolved
internal/rpc/proxy.go Outdated Show resolved Hide resolved
@alesstimec alesstimec force-pushed the juju-monitoring branch 2 times, most recently from c7f24c1 to 3e97d65 Compare June 12, 2024 10:51
Name: "call_duration_seconds",
Help: "Histogram of juju call time in seconds",
Buckets: []float64{.005, .01, .025, .05, .1, .25, .5, 1, 2.5, 5, 10},
}, []string{"facade", "method", "controller"})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Contributor

@ale8k ale8k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@alesstimec alesstimec requested a review from a team as a code owner June 13, 2024 07:06
@alesstimec alesstimec force-pushed the juju-monitoring branch 2 times, most recently from b789301 to 45c64d8 Compare June 13, 2024 08:08
@alesstimec alesstimec merged commit 8dd99b6 into canonical:v3 Jun 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants