-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Juju monitoring #1234
Merged
Merged
Juju monitoring #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
requested changes
Jun 12, 2024
alesstimec
force-pushed
the
juju-monitoring
branch
from
June 12, 2024 09:31
b91a369
to
dbb8887
Compare
kian99
requested changes
Jun 12, 2024
alesstimec
force-pushed
the
juju-monitoring
branch
from
June 12, 2024 09:54
7c5df34
to
00bf40f
Compare
kian99
approved these changes
Jun 12, 2024
alesstimec
force-pushed
the
juju-monitoring
branch
2 times, most recently
from
June 12, 2024 10:51
c7f24c1
to
3e97d65
Compare
ale8k
reviewed
Jun 12, 2024
Name: "call_duration_seconds", | ||
Help: "Histogram of juju call time in seconds", | ||
Buckets: []float64{.005, .01, .025, .05, .1, .25, .5, 1, 2.5, 5, 10}, | ||
}, []string{"facade", "method", "controller"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
ale8k
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
alesstimec
force-pushed
the
juju-monitoring
branch
from
June 13, 2024 07:06
3e97d65
to
915b7f1
Compare
alesstimec
force-pushed
the
juju-monitoring
branch
2 times, most recently
from
June 13, 2024 08:08
b789301
to
45c64d8
Compare
alesstimec
force-pushed
the
juju-monitoring
branch
from
June 13, 2024 08:39
45c64d8
to
34d0e20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The what and why - include a summary of the change, describe what it does, and include relevant motivation and context.
Fixes JIRA/GitHub issue number
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers