Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIMM rock #1235

Merged
merged 4 commits into from
Jun 13, 2024
Merged

JIMM rock #1235

merged 4 commits into from
Jun 13, 2024

Conversation

ale8k
Copy link
Contributor

@ale8k ale8k commented Jun 12, 2024

Tested via:

  1. Build rock
  2. Change compose img
  3. Spin up compose
  4. Change env for jimm svc to include vault from vault.env
  5. dc rm jimm
  6. dc up jimm (no-depps)
  7. Curled debug status

CI:
Tested on fork.

Also did a little cleanup of old script.

Description

The what and why - include a summary of the change, describe what it does, and include relevant motivation and context.

Fixes JIRA/GitHub issue number

Engineering checklist

Check only items that apply

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

Test instructions

Notes for code reviewers

Tested via:
1. Build rock
2. Change compose img
3. Spin up compose
4. Change env for jimm svc to include vault from vault.env
5. dc rm jimm
6. dc up jimm (no-depps)
7. Curled debug status

CI:
Tested on fork.
source: .
source-type: local
build-snaps:
- go/1.22/stable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I asked this in the Livepatch rock, but is there any way to detect the go version based on our go.mod?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could in theory just yq the file in place? I'm already ln'ing it? Will check the rock spec tho see if it can pickup on go mods

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing there, merged PR, happy to just manually update tbh for now

Copy link
Collaborator

@alesstimec alesstimec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few nitpicks

Makefile Show resolved Hide resolved
rocks/jimm.yaml Outdated Show resolved Hide resolved
rocks/jimm.yaml Outdated Show resolved Hide resolved
@ale8k ale8k requested a review from a team as a code owner June 13, 2024 07:43
@ale8k ale8k merged commit 52dd175 into canonical:v3 Jun 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants