jobs doesn't work #1241
Merged
jobs doesn't work #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
requested changes
Jun 14, 2024
Comment on lines
+38
to
+41
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ${{ steps.snapcraft.outputs.snap }} | ||
| path: ${{ steps.snapcraft.outputs.snap }} |
There was a problem hiding this comment.
This snap is not to be uploaded
There was a problem hiding this comment.
this was more to download from a url, what else do you suggest?
There was a problem hiding this comment.
Gotcha, I mistook the "upload-artifact" with the snapcraft upload. I guess all these steps need names.
kian99
approved these changes
Jun 17, 2024
Comment on lines
+38
to
+41
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ${{ steps.snapcraft.outputs.snap }} | ||
| path: ${{ steps.snapcraft.outputs.snap }} |
There was a problem hiding this comment.
Gotcha, I mistook the "upload-artifact" with the snapcraft upload. I guess all these steps need names.
babakks
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The what and why - include a summary of the change, describe what it does, and include relevant motivation and context.
Fixes JIRA/GitHub issue number
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers