Credential contents api call #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babakks
approved these changes
Jun 26, 2024
| res, err := s.API.CredentialContents(ctx, args) | ||
| c.Assert(err, gc.Equals, nil) | ||
| c.Assert(res.Results, gc.HasLen, 1) | ||
| } |
There was a problem hiding this comment.
Can you please add a test that looks up for a specific cloud credential?
kian99
approved these changes
Jun 26, 2024
| // If no specific credential name/cloud was passed in, all credentials for this user | ||
| // are returned. | ||
| // Only credential owner can see its contents as well as what models use it. | ||
| // Controller admin has no special superpowers here and is treated the same as all other users. |
There was a problem hiding this comment.
Wouldn't a controller admin be able to see all cloud creds on the controller?
| // If no specific credential name/cloud was passed in, all credentials for this user | ||
| // are returned. | ||
| // Only credential owner can see its contents as well as what models use it. | ||
| // Controller admin has no special superpowers here and is treated the same as all other users. |
There was a problem hiding this comment.
Should we keep this comment in one place or duplicate it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The what and why - include a summary of the change, describe what it does, and include relevant motivation and context.
Fixes JIRA/GitHub issue number
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers