Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css 9387 add rebac admin backend server #1262

Merged
merged 5 commits into from
Jul 19, 2024
Merged

Css 9387 add rebac admin backend server #1262

merged 5 commits into from
Jul 19, 2024

Conversation

pkulik0
Copy link
Contributor

@pkulik0 pkulik0 commented Jul 4, 2024

Description

This PR add a noop rebac admin ui backend server to JIMM for further development in the next tasks from this epic. Additionally remaining sysdeps target references were brought in line with the rest (sys-deps)

JIRA issue: CSS 9387

Engineering checklist

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

@pkulik0 pkulik0 requested a review from a team as a code owner July 4, 2024 10:40
@pkulik0 pkulik0 changed the base branch from v3 to feature-rebac-admin July 4, 2024 14:44
internal/rebac/auth.go Outdated Show resolved Hide resolved
service.go Outdated Show resolved Hide resolved
docker-compose.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@kian99 kian99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a comment on naming. Please also update the description of the PR.

internal/rebac/auth.go Outdated Show resolved Hide resolved
@pkulik0 pkulik0 merged commit b2d3ec6 into canonical:feature-rebac-admin Jul 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants