Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert dial and call all #1267

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

ale8k
Copy link
Contributor

@ale8k ale8k commented Jul 11, 2024

Description

We ended up creating a duplicate function for dialing all controllers, the only difference was the use of an errgroup. I can see martin wanted to return the first error as he wasn't sure which to return and ultimately for now we've been doing the same thing. Run all the calls, return the first error. As such this reverts and removes that call. It does keep the avoiding db logic still however.

Engineering checklist

Check only items that apply

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

Test instructions

Notes for code reviewers

@ale8k ale8k requested a review from a team as a code owner July 11, 2024 12:22
@kian99 kian99 mentioned this pull request Jul 16, 2024
3 tasks
@ale8k ale8k merged commit 5d49557 into canonical:v3-slim-jimm Jul 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants