Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved service files #1278

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Moved service files #1278

merged 4 commits into from
Jul 24, 2024

Conversation

kian99
Copy link
Contributor

@kian99 kian99 commented Jul 22, 2024

Description

This PR moves service.go, service_test.go and export.go away from the root of the directory and into a package called service within the pkg folder.

@kian99 kian99 requested a review from a team as a code owner July 22, 2024 12:29
Copy link
Contributor

@SimoneDutto SimoneDutto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kian99 kian99 force-pushed the move-service-files branch from e47b721 to 841975f Compare July 22, 2024 14:36
Copy link
Contributor

@pkulik0 pkulik0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestVault in service_test.go needs a prefix change on line 132 to make it work

@kian99
Copy link
Contributor Author

kian99 commented Jul 24, 2024

TestVault in service_test.go needs a prefix change on line 132 to make it work

Fixed, please take another look.

@kian99 kian99 requested a review from pkulik0 July 24, 2024 08:43
cmd/jimmsrv/service/service.go Show resolved Hide resolved
local/vault/approle.go Show resolved Hide resolved
Copy link
Contributor

@ale8k ale8k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think placing it in cmd makes a lot of sense and is now consistent with livepatch. LGTM!

@kian99 kian99 merged commit 7ea0867 into canonical:v3 Jul 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants