Allow querying groups by UUID #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ale8k
approved these changes
Jul 29, 2024
SimoneDutto
approved these changes
Jul 29, 2024
| @@ -12,7 +12,7 @@ const ( | |||
| ) | |||
|
|
|||
| var ( | |||
| validGroupName = regexp.MustCompile("^[a-zA-Z][a-zA-Z0-9._-]{4,}[a-zA-Z0-9]$") | |||
| validGroupName = regexp.MustCompile("^[a-zA-Z][a-zA-Z0-9._-]+[a-zA-Z0-9]$") | |||
There was a problem hiding this comment.
why did you change this? to comply with both uuid and name format?
There was a problem hiding this comment.
No, the description of the PR mentions the reason. It currently enforces that names must be 6 characters long - first group, second group 4 or more times, last group. The + makes the match "one or more" instead. So now the minimum length of a group name is 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows a user to reference JIMM groups by UUID much like we do for application-offers, models, controllers, etc.
Fixes CSS-9900
As a drive-by fix I noticed our group validation regex enforces group names to be at least 6 characters long. I've reduced that to 3.
Engineering checklist
Check only items that apply