Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema model for user public keys #1287

Merged
merged 9 commits into from
Jul 29, 2024
Merged

Schema model for user public keys #1287

merged 9 commits into from
Jul 29, 2024

Conversation

ale8k
Copy link
Contributor

@ale8k ale8k commented Jul 29, 2024

Description

In order to persist user's public keys, we require a model. This PR implements that.

Fixes JIRA/GitHub issue number

Engineering checklist

Check only items that apply

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

Test instructions

Notes for code reviewers

@ale8k ale8k requested a review from a team as a code owner July 29, 2024 08:23
Copy link
Contributor

@kian99 kian99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see 1 key per DB row.

internal/dbmodel/sql/postgres/1_12.sql Outdated Show resolved Hide resolved
internal/dbmodel/user_ssh_key.go Outdated Show resolved Hide resolved
@ale8k
Copy link
Contributor Author

ale8k commented Jul 29, 2024

I'd like to see 1 key per DB row.

done

}

// userSSHKey holds an SSH key for a user.
type userSSHKey struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would we not want this exported?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, use constructor

ale8k and others added 2 commits July 29, 2024 13:31
Co-authored-by: SimoneDutto <[email protected]>
Co-authored-by: Babak K. Shandiz <[email protected]>
Co-authored-by: Ales Stimec <[email protected]>
Co-authored-by: Kian Parvin <[email protected]>
Co-authored-by: Piotr Kulik <[email protected]>
@ale8k ale8k merged commit 36e1934 into canonical:feature-ssh-proxy Jul 29, 2024
3 checks passed
@kian99 kian99 mentioned this pull request Jan 10, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants