Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding a model with implicit cloud. #1325

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

alesstimec
Copy link
Collaborator

If the user does not specify which cloud to add the model to and only one cloud is known to JIMM, we will select that cloud and continue instead of returning an error.

Description

The what and why - include a summary of the change, describe what it does, and include relevant motivation and context.

Fixes JIRA/GitHub issue number

Engineering checklist

Check only items that apply

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

Test instructions

Notes for code reviewers

@alesstimec alesstimec requested a review from a team as a code owner August 26, 2024 09:39
Copy link
Contributor

@kian99 kian99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good with some tweaks

internal/jimm/model.go Outdated Show resolved Hide resolved
internal/jimm/model.go Show resolved Hide resolved
internal/jimm/model_test.go Outdated Show resolved Hide resolved
@kian99 kian99 mentioned this pull request Aug 26, 2024
3 tasks
@alesstimec alesstimec force-pushed the implicit-cloud-for-add-model branch 5 times, most recently from 57836cb to 749388e Compare August 26, 2024 11:17
If the user does not specify which cloud to add the model to and only
one cloud is known to JIMM, we will select that cloud and continue instead
of returning an error.
@alesstimec alesstimec force-pushed the implicit-cloud-for-add-model branch from 749388e to adcb70b Compare August 26, 2024 11:22
@alesstimec alesstimec merged commit c61fe72 into canonical:v3 Aug 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants