Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create model manager interface #1328

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

kian99
Copy link
Contributor

@kian99 kian99 commented Aug 27, 2024

Description

This is a housekeeping PR to split model facade methods into a separate interface as part of the ongoing effort to break down the large JIMM interface.

@kian99 kian99 requested a review from a team as a code owner August 27, 2024 06:38
alesstimec
alesstimec previously approved these changes Aug 27, 2024
internal/jujuapi/modelmanager.go Show resolved Hide resolved
pkulik0
pkulik0 previously approved these changes Aug 27, 2024
@kian99 kian99 dismissed stale reviews from pkulik0 and alesstimec via b797594 August 27, 2024 13:50
@kian99 kian99 force-pushed the modelmanager-interface branch from 56470d4 to b797594 Compare August 27, 2024 13:50
@kian99 kian99 requested review from alesstimec and pkulik0 August 27, 2024 13:51
Copy link
Contributor

@ale8k ale8k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty ty, helps split our mock up, eventually we wanna split the jimm struct itself somehow...

Copy link
Contributor

@pkulik0 pkulik0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kian99 kian99 merged commit 0364beb into canonical:v3 Aug 28, 2024
4 checks passed
kian99 added a commit to kian99/jimm that referenced this pull request Sep 3, 2024
* create model manager interface

* add godocs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants