fixes for composite action #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
requested review from
alesstimec,
SimoneDutto,
babakks,
ale8k and
pkulik0
ale8k
approved these changes
Sep 3, 2024
| shell: bash | ||
| working-directory: ${{ github.action_path }}/../../.. |
SimoneDutto
reviewed
Sep 3, 2024
| shell: bash | ||
| working-directory: ${{ github.action_path }}/../../.. |
There was a problem hiding this comment.
Second answer mentions that it should be possible to set a default work dir for each step in a action:
https://stackoverflow.com/questions/58139175/running-actions-in-another-directory
There was a problem hiding this comment.
Unfortunately it's not supported in composite actions, see Github's design doc here.
There was a problem hiding this comment.
in a follow up PR we will try the default on top of the job list, like so:
name: CI
on:
...
defaults:
run:
working-directory: ./app
SimoneDutto
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes some tweaks to JIMM composite action.
working_dirkeyword when referencing scripts in the repo alongside the${{ github.action_path }}context variable.I've tested these changes here.