Feature rebac admin #1351
Merged
Feature rebac admin #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-server Css 9387 add rebac admin backend server
* add entitlements api to rebac endpoint * update embed file names
…h handler + change its test
* WIP * Add handler for rebac group service add constructor for entitlement service * Update godoc * Pass JIMM to rebac_admin
Merge v3 rebac
* Add pagination to list groups method * Moved common package and made pagination package
* refactor jimm relations methods * rename parseTag to parseAndResolveTag
CSS 9386 authentication middleware
Avoid use of auth client outside of jimm
* identities listing * identity get
* Implement rebac group crud * improve tests and add group count * PR comments Added authentication for rebac-admin-ui enforcing that the user has to be a JIMM admin. * Better error handling * merge fixes * update auth middleware tests Accept a JIMM interface at the middleware rather than a concrete type to enable mock tests. * fix unit test
* implement group identities methods * PR comments and extra test logic * verify group exists
* add relation test * add identities endpoints
* Avoid use of DB outside of jimm * test fixes Replace hardcoded controller UUID in tests with constant * Export ControllerService Drive-by warning fix * minor refactoring * avoid returning a params type from jimm layer Rather than returning an apiParams type from the jimm layer in `ControllerInfo`, return a dbmodel. This also means it doesn't make sense to return the JIMM controller info since that is not a entity stored in the database. The construction of the JIMM controller info is kept directly in `jujuapi`. * update godocs
* implement GetGroupEntitlements * test fixes * address PR comments - More descriptive names - Minor tweaks to function signatures * add missing copyright lines * refactor functions to handle application logic at jimm layer * use concrete type in jimm layer rather than a string * revert move of function * added missing godocs/copyright and test fix
* implement patch group entitlements * minor change in creating error response * address follow-up comments from previous PR * PR comments
* add get identities entitlements * add patch identity entitlements
Merge v3 feature rebac admin
* resources endpoint
Merge v3 feature rebac admin
SimoneDutto
approved these changes
Sep 5, 2024
babakks
approved these changes
Sep 5, 2024
Merge v3 feature rebac admin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merges the
feature-rebac-adminbranch into `v3.The changes are in a stable state and ready to be merged into `v3.
Make sure to merge with a commit message to keep the history.