refactor[internal/openfga] simplifies some model access checks #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimoneDutto
approved these changes
Dec 6, 2024
| if err != nil { | ||
| return errors.E(op, err) | ||
| } | ||
| if !allowedModelAccess[access][accessLevel] { | ||
|
|
||
| if !hasAccess { |
There was a problem hiding this comment.
basically before we were handling hierarchy between roles manually? And now we rely on our authorization model, good
SimoneDutto
reviewed
Dec 6, 2024
| } | ||
| if hasReadAccess { | ||
| return "read", nil | ||
| func userModelAccess(ctx context.Context, user *openfga.User, model names.ModelTag) string { |
ale8k
approved these changes
Dec 10, 2024
| func userModelAccess(ctx context.Context, user *openfga.User, model names.ModelTag) string { | ||
| userRelation := user.GetModelAccess(ctx, model) | ||
| switch userRelation { | ||
| case ofganames.AdministratorRelation: |
There was a problem hiding this comment.
I know we have ofganames now, but I really think permission package with access constants would've been better from juju.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers