fix model default order #1487
Merged
fix model default order #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ale8k
approved these changes
Dec 11, 2024
SimoneDutto
commented
Dec 12, 2024
| @@ -245,6 +245,7 @@ func (b *modelBuilder) WithCloudRegion(region string) *modelBuilder { | |||
| continue | |||
| } | |||
| region = r.Name | |||
| break | |||
There was a problem hiding this comment.
i've added this break, because before it seemed to me it was wrong to continue the loop if you've already found a region.
Let me know if we were relying on this behaviour for some reason
alesstimec
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before we get the model defaults before getting the
implicitcloud and cloud region, this could result in having no default.Now we first get the implicit cloud and then we get the defaults.
Fixes JIRA/GitHub issue number
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers