Slim jimm model #1488
Merged
Slim jimm model #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove non-essential fields from model * remove fields from yaml env * refactor model summaries
* remove controller watcher
fix migration fix
SimoneDutto
force-pushed
the
slim-jimm-model
branch
from
6f69fc8 to
a5d440f
Compare
alesstimec
approved these changes
Dec 10, 2024
ale8k
approved these changes
Dec 11, 2024
| // modelSummariesMap is a safe map to add records concurrently because the access is guarded by a Mutex. | ||
| // The read operations are not guarded because only inserts are done concurrently. | ||
| type modelSummariesMap struct { | ||
| mu sync.Mutex |
There was a problem hiding this comment.
Can just use sync.Map, no need for mutex @SimoneDutto
There was a problem hiding this comment.
from the go doc, you use sync.Map for very specific use case. Usually they advice you to use a separate mutex.
There was a problem hiding this comment.
Ah I see, so if routine A handles keys 1-10, and routine B handled keys 11-20, then sync.Map is preferred. Never noticed the second part really.
| @@ -71,6 +71,7 @@ type ModelManager interface { | |||
| ImportModel(ctx context.Context, user *openfga.User, controllerName string, modelTag names.ModelTag, newOwner string) error | |||
| ModelDefaultsForCloud(ctx context.Context, user *dbmodel.Identity, cloudTag names.CloudTag) (jujuparams.ModelDefaultsResult, error) | |||
| ModelInfo(ctx context.Context, u *openfga.User, mt names.ModelTag) (*jujuparams.ModelInfo, error) | |||
| ModelSummaries(ctx context.Context, user *openfga.User, maskingControllerUUID string) (jujuparams.ModelSummaryResults, error) | |||
There was a problem hiding this comment.
This interface is confusing lol (not you)
|
|
||
| // ModelSummaries returns the list of modelsummary the user has access to. | ||
| // It queries the controllers and then merge the info from the JIMM db. | ||
| func (j *JIMM) ModelSummaries(ctx context.Context, user *openfga.User, maskingControllerUUID string) (jujuparams.ModelSummaryResults, error) { |
There was a problem hiding this comment.
Probavbly better to just name it ListModelSummaries right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feature-brach into v3, with merge conflicts
Fixes JIRA/GitHub issue number
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers