Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(permissionmap): fixes our permission map to actually run the redi… #1490

Closed

Conversation

ale8k
Copy link
Contributor

@ale8k ale8k commented Dec 10, 2024

…al logic

Originally, when dialing controller we specified superuser for controllers, and admin for models. This was wrong and needed updating.

Now, we dial controllers with the minimum access to receive the "permission check required" error. Upon receiving this error, the redial logic within Call() will run and update the map. If we decide a call is to be "superuser", we do allow this override.

I've removed where we specify permissions as when redialling, even if we did have permissions and they were wrong (for example read for a DumpModelsDB), juju responds with "permission check required" and due to our redial logic we update the map on the redial. As such, its very likely we don't need to put permissions in ourselves and let the redial logic run. I am really unkeen on how we're having to redial and am going to fix this in a follow up.

Engineering checklist

Check only items that apply

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

Test instructions

Notes for code reviewers

@ale8k ale8k requested a review from a team as a code owner December 10, 2024 20:59
@ale8k ale8k closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant