feat(modelmanager): listmodels #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The api was trying to call /version, but our mock didn't implement it.
We now list models via contacting controllers directly.
ale8k
changed the title
SimoneDutto
requested changes
Dec 12, 2024
alesstimec
requested changes
Dec 13, 2024
| } | ||
|
|
||
| // Find the controllers these models reside on and remove duplicates | ||
| var controllers []dbmodel.Controller |
There was a problem hiding this comment.
i wonder if there's a way we could write this bit with generics or something, because we seem to be looking for unique lists in a few places in jimm code. also not for this pr :)
SimoneDutto
reviewed
Dec 13, 2024
SimoneDutto
requested changes
Dec 13, 2024
SimoneDutto
reviewed
Dec 13, 2024
alesstimec
reviewed
Dec 13, 2024
SimoneDutto
reviewed
Dec 13, 2024
alesstimec
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListModels now correctly calls ListModels. Dialing the controllers themselves and returning models only those users can view. This is used upon Login and Register commands to persist model details, and whether or not it is a CAAS model.
We don't return controller models as with JIMM this does not make sense - we intentionally choose not to expose these details to the user.
Driveby: The api was trying to call /version, but our mock didn't implement it.
Description
The what and why - include a summary of the change, describe what it does, and include relevant motivation and context.
Fixes JIRA/GitHub issue number
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers