Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cve fix #1495

Merged
merged 3 commits into from
Dec 13, 2024
Merged

cve fix #1495

merged 3 commits into from
Dec 13, 2024

Conversation

ale8k
Copy link
Contributor

@ale8k ale8k commented Dec 12, 2024

Description

High CVE fix. Fixes: https://github.com/canonical/jimm/security/dependabot/16 .

Engineering checklist

Check only items that apply

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

Test instructions

Notes for code reviewers

@ale8k ale8k requested a review from a team as a code owner December 12, 2024 14:37
Copy link
Contributor

@SimoneDutto SimoneDutto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a link to the security issue? so in the future we can try why this pr was merged in.

@ale8k
Copy link
Contributor Author

ale8k commented Dec 12, 2024

can you add a link to the security issue? so in the future we can try why this pr was merged in.

Like copy and paste the link from security tab? I think we probably want a standard for this. Like another PR template specifically for CVEs. What do you think?

@SimoneDutto
Copy link
Contributor

can you add a link to the security issue? so in the future we can try why this pr was merged in.

Like copy and paste the link from security tab? I think we probably want a standard for this. Like another PR template specifically for CVEs. What do you think?

yes, a standard would be great. Until we have it, a simple c/p of the link from the security tab is ok

@ale8k ale8k merged commit 3b226f0 into canonical:v3 Dec 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants