feat(jimmctl migrate): enable users to specify model names #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
reviewed
Dec 17, 2024
ale8k
force-pushed
the
juju-7322/improve-usability-of-migrate-command
branch
from
d124ac8 to
6494529
Compare
SimoneDutto
approved these changes
Dec 19, 2024
internal/jimm/jimm.go
Outdated
| if err != nil { | ||
| s := strings.Split(modelNameOrUUID, "/") | ||
| if len(s) != 2 { | ||
| return jujuparams.InitiateMigrationResult{}, errors.E(op, "missing model name") |
There was a problem hiding this comment.
this is more "invalid target" right? because we don't know if the model or the user name is wrong
There was a problem hiding this comment.
Yeah true, I'll update it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables users to specify model names when migrating. Fixes #1371
Engineering checklist
Test instructions