chore: remove unneeded getters #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove getters that allowed accessing the database or authorization client from outside the application layer.
kian99
force-pushed
the
remove-unneded-getters
branch
from
d08c2cc to
df9ec72
Compare
alesstimec
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove getters that allowed accessing the database or authorization client from outside the application layer.
Methods like
DB()orAuthorizationClient()were previously necessary when we had code injujuapimanipulating the database or adding/removing access tuples. Now that that has all been moved to the app layer insidejimmwe can get rid of these getters.