ci: add Tiobe TICS nightly workflow with coverage #225
+92
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiubelu
force-pushed
the
tics-nighly-scan
branch
from
a928ad2 to
321c836
Compare
BenchmarkResultsCurrent status |
claudiubelu
force-pushed
the
tics-nighly-scan
branch
6 times, most recently
from
571c33f to
cadf82e
Compare
claudiubelu
changed the title
claudiubelu
force-pushed
the
tics-nighly-scan
branch
from
cadf82e to
81fd12c
Compare
Closed
louiseschmidtgen
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Thank you @claudiubelu!
Two small suggestions. Once addressed please go ahead and merge.
Comment on lines
+84
to
+87
| export PYTHONPATH="$(pwd)/test/performance/tests/" | ||
|
|
||
| # TICSQServer will try to build the project. We need a few environment variables | ||
| # for it to succeed. Based on make static / "hack/static-dqlite.sh". | ||
| export INSTALL_DIR="$(pwd)/hack/.deps/static" | ||
| export PATH="${PATH}:${INSTALL_DIR}/musl/bin" | ||
| export CC=musl-gcc | ||
| export CGO_CFLAGS="-I${INSTALL_DIR}/include" | ||
| export CGO_LDFLAGS="-L${INSTALL_DIR}/lib -luv -ldqlite -llz4 -lsqlite3 -Wl,-z,stack-size=1048576" |
There was a problem hiding this comment.
A little style suggestion. We could also set the variables under env: in the step as described here: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#defining-environment-variables-for-a-single-workflow
There was a problem hiding this comment.
I think we can leave this as is. These env vars include other env vars, and the env: section does not allow for this type of thing, and the result would be worse than the current version, especially for $PATH.
claudiubelu
force-pushed
the
tics-nighly-scan
branch
3 times, most recently
from
e5d5636 to
51c27b6
Compare
* add new `go.coverage` Makefile target * add nightly workflow for running TICS scan Signed-off-by: Claudiu Belu <[email protected]> Signed-off-by: Nashwan Azhari <[email protected]> Co-Authored-By: Nashwan Azhari <[email protected]>
claudiubelu
force-pushed
the
tics-nighly-scan
branch
from
51c27b6 to
1df99b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds TICS nightly scan github action.
go.coverageMakefile targetBased on: #204
Also verify you have: