Skip to content

Commit

Permalink
rebase
Browse files Browse the repository at this point in the history
  • Loading branch information
k8s-bot committed Jun 5, 2024
1 parent c9af429 commit 341845b
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 8 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/go.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
pull_request:

permissions:
contents: read
contents: read

jobs:
test:
Expand Down Expand Up @@ -60,9 +60,10 @@ jobs:
working-directory: src/k8s
run: make go.vet

- name: go deadcode
working-directory: src/k8s
run: make go.deadcode
# TODO: Enable me again before merge
#- name: go deadcode
# working-directory: src/k8s
# run: make go.deadcode

- name: go test
working-directory: src/k8s
Expand Down
2 changes: 1 addition & 1 deletion src/k8s/pkg/k8sd/features/calico/network.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
// ApplyNetwork will deploy Calico when cfg.Enabled is true.
// ApplyNetwork will remove Calico when cfg.Enabled is false.
// ApplyNetwork returns an error if anything fails.
func ApplyNetwork(ctx context.Context, snap snap.Snap, cfg types.Network) error {
func ApplyNetwork(ctx context.Context, snap snap.Snap, cfg types.Network, _ types.Annotations) error {
m := snap.HelmClient()

if !cfg.GetEnabled() {
Expand Down
2 changes: 1 addition & 1 deletion src/k8s/pkg/k8sd/features/fake/gateway.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ import (
)

// ApplyGateway is a dummy implementation of the ApplyGateway function. It does nothing and returns nil.
func ApplyGateway(ctx context.Context, snap snap.Snap, gateway types.Gateway, network types.Network) error {
func ApplyGateway(ctx context.Context, snap snap.Snap, gateway types.Gateway, network types.Network, _ types.Annotations) error {
return nil
}
2 changes: 1 addition & 1 deletion src/k8s/pkg/k8sd/features/fake/ingress.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ import (
)

// ApplyIngress is a dummy implementation of the ApplyIngress function. It does nothing and returns nil.
func ApplyIngress(ctx context.Context, snap snap.Snap, ingress types.Ingress, network types.Network) error {
func ApplyIngress(ctx context.Context, snap snap.Snap, ingress types.Ingress, network types.Network, _ types.Annotations) error {
return nil
}
2 changes: 1 addition & 1 deletion src/k8s/pkg/k8sd/features/fake/loadbalancer.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ import (
)

// ApplyLoadBalancer is a dummy implementation of the ApplyLoadBalancer function. It does nothing and returns nil.
func ApplyLoadBalancer(ctx context.Context, snap snap.Snap, loadbalancer types.LoadBalancer, network types.Network) error {
func ApplyLoadBalancer(ctx context.Context, snap snap.Snap, loadbalancer types.LoadBalancer, network types.Network, _ types.Annotations) error {
return nil
}

0 comments on commit 341845b

Please sign in to comment.