Use PreRunE for sub-commands #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neoaggelos
approved these changes
Feb 28, 2024
By default, PersistentPreRun hooks are not chained. If a child command overwrites this, the parent hook is not executed. This caused the global permissions check to be overwritten in the sub-commands and caused misleading error messages when running commands without root permission.
bschimke95
force-pushed
the
bschimke95/fix-root-permission-check
branch
from
45899bc
to
8e9195d
Compare
eaudetcobello
pushed a commit
that referenced
this pull request
Feb 28, 2024
By default, PersistentPreRun hooks are not chained. If a child command overwrites this, the parent hook is not executed. This caused the global permissions check to be overwritten in the sub-commands and caused misleading error messages when running commands without root permission.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, PersistentPreRun hooks are not chained. If a child command overwrites this, the parent hook is not executed.
This caused the global permissions check to be overwritten in the sub-commands and caused misleading error messages when running commands without root permission.
There is a flag to introduce the chaining behavior but this unnecessarily complicates the commands. Since we have shallow command, using
PreRunhooks is just fine.Btw, we are not the only ones that got confused by this feature: spf13/cobra#252