Add cilium-dbg cleanup to snap removal hook #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschimke95
reviewed
Apr 3, 2024
neoaggelos
reviewed
Apr 3, 2024
berkayoz
force-pushed
the
KU-546/cilium-dbg-cleanup
branch
from
6fe5824
to
d332e47
Compare
|
neoaggelos
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cilium-dbg cleanup to snap removal hook for proper cleanup of nodeThis adds 20MB extra size to the snap, going to modify the rock to put the binary in place instead
Will be merged in after canonical/cilium-rocks#8