Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add moonray implementation and go ignore tags #473

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

bschimke95
Copy link
Contributor

@bschimke95 bschimke95 commented Jun 5, 2024

Add moonray implementation that (will) contain the features for moonray. This is ignored by default and only enabled by the moonray patch (which in turn also disables the default_implementation)

@bschimke95 bschimke95 requested a review from a team as a code owner June 5, 2024 11:57
@bschimke95 bschimke95 force-pushed the bschimke95/moonray-go-tag branch 2 times, most recently from d2b3c2a to 8528e25 Compare June 5, 2024 14:54
@bschimke95 bschimke95 changed the title add moonray go build tags Add moonray implementation and go ignore tags Jun 5, 2024
@bschimke95 bschimke95 force-pushed the bschimke95/moonray-go-tag branch 2 times, most recently from ba37890 to c7e4a91 Compare June 5, 2024 20:42
Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschimke95 bschimke95 merged commit 910305d into main Jun 6, 2024
15 checks passed
@bschimke95 bschimke95 deleted the bschimke95/moonray-go-tag branch June 6, 2024 07:48
eaudetcobello pushed a commit that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants