Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epa howto #658

Merged
merged 46 commits into from
Sep 18, 2024
Merged

Epa howto #658

merged 46 commits into from
Sep 18, 2024

Conversation

evilnick
Copy link
Contributor

@evilnick evilnick commented Sep 9, 2024

This is the epa howto. there are a few questions to address and actually some tidying up still to be done (hence draft), but it is completed enough to start looking over and reviewing

@evilnick evilnick changed the title Ku 1400/epa howto Epa howto Sep 9, 2024
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
Copy link
Contributor

@eaudetcobello eaudetcobello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Formatting issue prevents me from continuing the review.

docs/src/snap/howto/epa.md Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of comments, thanks for making this doc shiny @evilnick!

docs/src/snap/howto/epa.md Show resolved Hide resolved
docs/src/snap/howto/epa.md Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
docs/src/snap/howto/epa.md Show resolved Hide resolved
docs/src/snap/howto/epa.md Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
evilnick and others added 3 commits September 10, 2024 18:59
Co-authored-by: Louise K. Schmidtgen <[email protected]>
Co-authored-by: Louise K. Schmidtgen <[email protected]>
Co-authored-by: Louise K. Schmidtgen <[email protected]>
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need another cup of tea! I've left a lot of comments on the docs. Please remind me to have another look once you've addressed the markdown render issues in the later section of the doc.

Please consider thinking about breaking this doc up into more than one page under an epa folder.

Thank you for tackling this huge Doc!

docs/src/snap/howto/epa.md Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
docs/src/snap/howto/epa.md Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
docs/src/snap/howto/epa.md Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - only a couple of nit comments. Feel free to ignore them

docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
docs/src/snap/howto/epa.md Outdated Show resolved Hide resolved
evilnick and others added 17 commits September 18, 2024 11:01
* Add more sections to the CAPI docs

* Address comments
---------

Co-authored-by: Nick Veitch <[email protected]>
At the moment, the "k8sd cluster-recover" displays interactive
prompts and text editors that assist the user in updating the dqlite
configuration.

We need to be able to run the command non-interactively in order
to automate the cluster recovery procedure.

This change adds a "--non-interactive" flag. If set, we'll no longer
show confirmation prompts and we'll assume that the configuration
files have already been updated, proceeding with the dqlite recovery.
---------

Co-authored-by: Yanisa Haley Scherber <[email protected]>
* Automerge every 4-hours any PR with passing tests labeled with 'automerge'
* Make sure the bot can approve the PRs too
* Update Bot information only if git email currently unset
* consistently use private key secret to setup ssh git-remote
* Rename secret to BOT_SSH_KEY
* Reimagine auto-merge scripts as python
Warnings that k8s service may not work (#657)
KU-1475
@evilnick evilnick dismissed eaudetcobello’s stale review September 18, 2024 10:22

changes already addressed

@evilnick evilnick merged commit 1a993cc into main Sep 18, 2024
19 of 20 checks passed
@evilnick evilnick deleted the KU-1400/epa-howto branch September 18, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants