Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the issue template for creating release branches #677

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

addyess
Copy link
Contributor

@addyess addyess commented Sep 17, 2024

Overviews the release template

Based on #666 , improved the process to create release branches

@addyess addyess requested a review from a team as a code owner September 17, 2024 15:00
@addyess addyess force-pushed the KU-1572/update-issue-template/create-release-branch branch from 4ffd2c9 to 462d66f Compare September 17, 2024 15:00
@addyess addyess mentioned this pull request Sep 17, 2024
34 tasks
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only minor comments/questions

.github/ISSUE_TEMPLATE/create_release_branch.md Outdated Show resolved Hide resolved
@@ -89,7 +89,7 @@ The steps are to be followed in-order, each task must be completed by the person
- [ ] **Owner**: Create `release-1.xx` branch from latest `main` in rawfile-localpv
- `git clone [email protected]:canonical/rawfile-localpv.git ~/tmp/release-1.xx`
- `pushd ~/tmp/release-1.xx`
- `git switch main`
- `git switch rockcraft`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh? Why do we have this weird main branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the "default" branch of the rawfile-localpv b/c this is a forked repo and rather than working out of main (as the upstream author does) we do our work out of the rockcraft branch. We're trying to get the rockcraft work upstreamed...

so for the moment "OUR" main is rockcraft

@addyess addyess force-pushed the KU-1572/update-issue-template/create-release-branch branch from 462d66f to 7e68087 Compare September 17, 2024 15:11
@addyess addyess merged commit d0b57d1 into main Sep 17, 2024
20 checks passed
@addyess addyess deleted the KU-1572/update-issue-template/create-release-branch branch September 17, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants