Add feature annotations to the reference page #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, looks like pyspelling job found some issues, you can check it here |
|
Hi, looks like pyspelling job found some issues, you can check it here |
louiseschmidtgen
approved these changes
Oct 23, 2024
| | `k8sd/v1alpha1/calico/autodetection-v6/canReach` | Enable IP auto-detection based on which source address on the node is used to reach the specified IP or domain. | string | | ||
| | `k8sd/v1alpha1/calico/autodetection-v6/cidrs` | Enable IP auto-detection based on which addresses on the nodes are within one of the provided CIDRs. | []string (comma separated) | | ||
| | `k8sd/v1alpha1/cilium/devices` | List of devices facing cluster/external network (used for BPF NodePort, BPF masquerading and host firewall); supports `+` as wildcard in device name, e.g. `eth+` | string | | ||
| | `k8sd/v1alpha1/cilium/direct-routing-device` | Device name used to connect nodes in direct routing mode (used by BPF NodePort, BPF host routing; if empty, automatically set to a device with k8s InternalIP/ExternalIP or with a default route bridge type devices are ignored in automatic selection | string | |
There was a problem hiding this comment.
Suggested change
| | `k8sd/v1alpha1/cilium/direct-routing-device` | Device name used to connect nodes in direct routing mode (used by BPF NodePort, BPF host routing; if empty, automatically set to a device with k8s InternalIP/ExternalIP or with a default route bridge type devices are ignored in automatic selection | string | | |
| | `k8sd/v1alpha1/cilium/direct-routing-device` | Device name used to connect nodes in direct routing mode (used by BPF NodePort, BPF host routing. If the flag is undefined, device name is automatically set to a device with k8s InternalIP/ExternalIP or to a default route bridge. Type devices are ignored in automatic selection | string | |
This doesn't flow quite right, maybe re-word it to something like this:
There was a problem hiding this comment.
This is from the upstream docs, seems like I messed up the formatting should be better now
--------- Co-authored-by: Louise K. Schmidtgen <[email protected]>
|
Hi, looks like pyspelling job found some issues, you can check it here |
|
I think you're missing k8sd/v1alpha1/csrsigning/auto-approve ? |
|
Hi, looks like pyspelling job found some issues, you can check it here |
eaudetcobello
approved these changes
Oct 25, 2024
| @@ -8,6 +8,28 @@ the bootstrap configuration. | |||
| |---------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-----------------| | |||
| | `k8sd/v1alpha/lifecycle/skip-cleanup-kubernetes-node-on-remove` | If set, only microcluster and file cleanup are performed. This is helpful when an external controller (e.g., CAPI) manages the Kubernetes node lifecycle. By default, k8sd will remove the Kubernetes node when it is removed from the cluster. | "true"\|"false" | | |||
| | `k8sd/v1alpha/lifecycle/skip-stop-services-on-remove` | If set, the k8s services will not be stopped on the leaving node when removing the node. This is helpful when an external controller (e.g., CAPI) manages the Kubernetes node lifecycle. By default, all services are stopped on leaving nodes. | "true"\|"false" | | |||
| | `k8sd/v1alpha1/csrsigning/auto-approve` | If set, certificate signing requests created by worker nodes are auto approved. | "true"\|"false" | | |||
There was a problem hiding this comment.
Maybe @evilnick / @nhennigan can we change the width of the Description column it renders quite oddly:
There was a problem hiding this comment.
Will take a look but maybe a table isn't the best option here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature annotations to the reference page