Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded annotations #763

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Remove hardcoded annotations #763

merged 3 commits into from
Nov 12, 2024
+20 −14

Conversation

eaudetcobello
Copy link
Contributor

@eaudetcobello eaudetcobello requested a review from a team as a code owner October 24, 2024 12:30
HomayoonAlimohammadi
HomayoonAlimohammadi approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing these @eaudetcobello! LGTM

@bschimke95
Copy link
Contributor

Please fix the diff checker, then we can merge this.

@github-actions GitHub Actions
Copy link
Contributor

Hi, looks like pyspelling job found some issues, you can check it here

@eaudetcobello eaudetcobello changed the title rm hardcoded annotations Remove hardcoded annotations Nov 12, 2024
@eaudetcobello eaudetcobello merged commit 86b5a29 into main Nov 12, 2024
20 of 21 checks passed
@eaudetcobello eaudetcobello deleted the rm-hardcoded-annotations branch November 12, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HomayoonAlimohammadi HomayoonAlimohammadi HomayoonAlimohammadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eaudetcobello @bschimke95 @HomayoonAlimohammadi