Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add min-tls-version flag #776

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Add min-tls-version flag #776

merged 1 commit into from
Nov 8, 2024

Conversation

bschimke95
Copy link
Contributor

DISA requires a TLS version of 1.2 as a minimum.

@bschimke95
Add min-tls-version flag
e5eaf57 
DISA requires a TLS version of 1.2 as a minimum.
@bschimke95 bschimke95 requested a review from a team as a code owner November 8, 2024 09:15
HomayoonAlimohammadi
HomayoonAlimohammadi approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @bschimke95. LGTM, just a minor comment.

src/k8s/pkg/k8sd/setup/kube_apiserver.go Show resolved Hide resolved
@bschimke95
Copy link
Contributor Author

SBOM etc fail because of other issues, not related to this PR - merging.

@bschimke95 bschimke95 merged commit d6de281 into main Nov 8, 2024
16 of 19 checks passed
@bschimke95 bschimke95 deleted the KU-2082/minTLSversion branch November 8, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HomayoonAlimohammadi HomayoonAlimohammadi HomayoonAlimohammadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bschimke95 @HomayoonAlimohammadi