Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SBOM generation #780

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Fix SBOM generation #780

merged 2 commits into from
Nov 8, 2024

Conversation

bschimke95
Copy link
Contributor

The folder structure of the CoreDNS rock has changed. This hardcoded version is a temporary fix to make the CI happy again.
A refactoring of the SBOM generation is done as follow-up work.

@bschimke95 bschimke95 requested a review from a team as a code owner November 8, 2024 11:00
@ktsakalozos
Copy link
Member

Do you want the sbom tarball in the PR?

@bschimke95
Copy link
Contributor Author

Nope - thanks for the catch

Copy link
Contributor

@eaudetcobello eaudetcobello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please make sure we have a card for the follow-up work

@bschimke95
Copy link
Contributor Author

We do have.

@bschimke95 bschimke95 merged commit ca54963 into main Nov 8, 2024
19 of 20 checks passed
@bschimke95 bschimke95 deleted the bschimke95/fix-sbom-generation branch November 8, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants