Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove kroki and replace with SVGS for now #781

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

evilnick
Copy link
Contributor

@evilnick evilnick commented Nov 8, 2024

Kroki causes issues with:

  • rate limiting as we are too lazy to host this ourselves
  • build problems on different versions of Python

This PR removes the kroki extension, the directives in the text and replaces with static SVG images until we determine a better replacement.

@evilnick evilnick requested a review from a team as a code owner November 8, 2024 11:13
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Hi, looks like pyspelling job found some issues, you can check it here

Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@evilnick evilnick merged commit 297bed5 into main Nov 8, 2024
6 checks passed
@evilnick evilnick deleted the KU-1981-replace-kroki branch November 8, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants