Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary fix for sbom generation for metrics-server #787

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Temporary fix for sbom generation for metrics-server #787

merged 1 commit into from
Nov 11, 2024

Conversation

berkayoz
Copy link
Member

Temporary fix for sbom generation for metrics-server

@berkayoz berkayoz requested a review from a team as a code owner November 11, 2024 08:17
louiseschmidtgen
louiseschmidtgen approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, consider making 0.7.0/rockcraft.yaml a variable. This way, we only have it hard-coded in one place until updated.

@berkayoz berkayoz merged commit f6ef548 into main Nov 11, 2024
17 of 19 checks passed
@berkayoz berkayoz deleted the fix/metrics-server-sbom branch November 11, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louiseschmidtgen louiseschmidtgen louiseschmidtgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berkayoz @louiseschmidtgen