Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated katib-ui-rock #45

Merged
merged 5 commits into from
Sep 2, 2024
Merged

Updated katib-ui-rock #45

merged 5 commits into from
Sep 2, 2024

Conversation

TakoB222
Copy link
Contributor

Description


  • Added tests
  • Added tox.ini

@TakoB222 TakoB222 requested a review from a team as a code owner July 22, 2024 11:04
@TakoB222 TakoB222 changed the title Updated `katib-ui-rock Updated katib-ui-rock Jul 22, 2024
Copy link
Member

@misohu misohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TakoB222 good job with the update :)

I am having small problems by running it locally the service just quits with

❯ sudo rockcraft.skopeo --insecure-policy copy oci-archive:katib-ui_v0.17.0_amd64.rock docker-daemon:katib-ui:latest
Getting image source signatures
Copying blob c3d7a1af29e9 done   | 
Copying blob 25faaacc33ff done   | 
Copying blob 8f9917b730eb done   | 
Copying blob ef286963ba66 done   | 
Copying blob 80e5cf5427a8 done   | 
Copying config 226b92e014 done   | 
Writing manifest to image destination
❯ docker run katib-ui:latest
2024-08-28T06:24:37.438Z [pebble] Started daemon.
2024-08-28T06:24:37.472Z [pebble] POST /v1/services 17.432032ms 202
2024-08-28T06:24:37.488Z [pebble] Service "katib-ui" starting: ./katib-ui
2024-08-28T06:24:37.534Z [pebble] Change 1 task (Start service "katib-ui") failed: cannot start service: exited quickly with code 2
2024-08-28T06:24:37.566Z [pebble] GET /v1/changes/1/wait 92.644523ms 200
2024-08-28T06:24:37.566Z [pebble] Started default services with change 1.
^C2024-08-28T06:26:14.000Z [pebble] Exiting on interrupt signal.

While the expected behavior with the upstream image is this:

❯ docker run docker.io/kubeflowkatib/katib-ui:v0.17.0
Unable to find image 'kubeflowkatib/katib-ui:v0.17.0' locally
v0.17.0: Pulling from kubeflowkatib/katib-ui
d078792c4f91: Pull complete 
bc5bbb33ad64: Pull complete 
d44e239a55f1: Pull complete 
03470febe599: Pull complete 
Digest: sha256:7a41c508deb1f9c41ee27723c2dcddaf8d4f0832acab0254dac3a2b16f7a924f
Status: Downloaded newer image for kubeflowkatib/katib-ui:v0.17.0
2024/08/28 06:26:47 NewClient for Katib failed: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable
panic: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable

goroutine 1 [running]:
github.com/kubeflow/katib/pkg/ui/v1beta1.NewKatibUIHandler({0xc00011c080, 0x1e})
	/go/src/github.com/kubeflow/katib/pkg/ui/v1beta1/backend.go:53 +0x16d
main.main()
	/go/src/github.com/kubeflow/katib/cmd/ui/v1beta1/main.go:44 +0x70	

Do we know what could be the problem ?

@kimwnasptd
Copy link
Contributor

@misohu you'll need to execute the docker image with -v at the end with the docker command
https://matrix.to/#/!NPPCseDHKRvSBMUEXN:ubuntu.com/$8yiB2hQcbEmVuDr8dJ31Sf2smWOWJqa99p9ni7srDEY?via=ubuntu.com&via=matrix.org

Copy link
Member

@misohu misohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kimwnasptd logs look the same approving

@misohu misohu merged commit 158182c into canonical:main Sep 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants