Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permission in suggestion-enas #51

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

misohu
Copy link
Member

@misohu misohu commented Sep 3, 2024

Closes: #50

Add correct permissions for the user in the rock.

How to test:

cd suggestion-enas
rockcraft clean && rockcraft pack --verbosity=trace --debug 
sudo rockcraft.skopeo --insecure-policy copy oci-archive:suggestion-enas_v0.17.0_amd64.rock docker-daemon:misohu/suggestion-enas:0.17.0
docker run -ti  misohu/suggestion-enas:0.17.0 -v

expected output

2024-09-03T13:24:25.749Z [pebble] Started daemon.
2024-09-03T13:24:25.784Z [pebble] POST /v1/services 16.991767ms 202
2024-09-03T13:24:25.800Z [pebble] Service "suggestion-enas" starting: python3 main.py
2024-09-03T13:24:26.093Z [suggestion-enas] 2024-09-03 13:24:26.093490: I tensorflow/core/util/port.cc:113] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`.
2024-09-03T13:24:26.093Z [suggestion-enas] 2024-09-03 13:24:26.093835: I external/local_tsl/tsl/cuda/cudart_stub.cc:32] Could not find cuda drivers on your machine, GPU will not be used.
2024-09-03T13:24:26.095Z [suggestion-enas] 2024-09-03 13:24:26.095833: I external/local_tsl/tsl/cuda/cudart_stub.cc:32] Could not find cuda drivers on your machine, GPU will not be used.
2024-09-03T13:24:26.122Z [suggestion-enas] 2024-09-03 13:24:26.122534: I tensorflow/core/platform/cpu_feature_guard.cc:210] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
2024-09-03T13:24:26.122Z [suggestion-enas] To enable the following instructions: AVX2 AVX_VNNI FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
2024-09-03T13:24:26.553Z [suggestion-enas] 2024-09-03 13:24:26.553603: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
2024-09-03T13:24:26.827Z [pebble] GET /v1/changes/1/wait 1.042654734s 200
2024-09-03T13:24:26.827Z [pebble] Started default services with change 1.
^C2024-09-03T13:24:34.474Z [pebble] Exiting on interrupt signal.
2024-09-03T13:24:34.498Z [pebble] Stopping all running services.
2024-09-03T13:24:34.543Z [pebble] Service "suggestion-enas" stopped

no permission denied.

I have also tested locally with katib-operator experiment. No problems there.

@misohu misohu requested a review from a team as a code owner September 3, 2024 13:28
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock. From our sync, I don't think there's a better way to set permissions while also using the dump plugin and organize, but let's ask rockcraft to ensure we 're following best practices and update the rock if needed

@misohu misohu merged commit 3a8d15a into main Sep 4, 2024
7 checks passed
@rgildein rgildein deleted the KF-6198-fix-suggestion-enas-permission branch September 10, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suggestion-enas rock permission denied error
2 participants