Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix args in metrics collector #52

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

misohu
Copy link
Member

@misohu misohu commented Sep 3, 2024

Closes: #49

Pass arguments to the metrics collector.

Test locally:

cd file-metrics-collector
rockcraft clean && rockcraft pack --verbosity=trace --debug 
sudo rockcraft.skopeo --insecure-policy copy oci-archive:file-metrics-collector_v0.17.0_amd64.rock docker-daemon:misohu/file-metrics-collector:0.17.0
docker run -ti  misohu/file-metrics-collector:0.17.0 -v

Expected output:

2024-09-03T13:33:43.524Z [pebble] Started daemon.
2024-09-03T13:33:43.555Z [pebble] POST /v1/services 15.744369ms 202
2024-09-03T13:33:43.570Z [pebble] Service "file-metrics-collector" starting: /app/file-metricscollector [ -v ]
2024-09-03T13:33:43.589Z [pebble] Change 1 task (Start service "file-metrics-collector") failed: cannot start service: exited quickly with code 2
2024-09-03T13:33:43.622Z [pebble] GET /v1/changes/1/wait 66.977009ms 200
2024-09-03T13:33:43.622Z [pebble] Started default

As we can see the -v is passed to the service.

I have also tested this rock locally with katib-bundle integration tests.

@misohu misohu requested a review from a team as a code owner September 3, 2024 13:36
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @misohu LGTM, I tested with bundle integration tests from track/0.17 and they passed

@misohu misohu merged commit 867ad83 into main Sep 4, 2024
7 checks passed
@rgildein rgildein deleted the KF-6196-metrics-collector-pass-args branch September 10, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

file-metrics-collector rock is not accepting args
2 participants